PackageCollectionsSigning: correct BoringSSLCertificate.keyType(of:)
#3679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function takes a named argument which is the `EVP_PKEY` and checks the underlying public key type (expected to be one of RSA or EC). However, instead of checking the key type of the given public key, it was always returning the key type of the underlying certificate. This happened to give the correct result as the current usage always used the same object to get the key. This corrects that and uses the proper accessors for the value.
compnerd
requested review from
abertelrud,
friedbunny,
neonichu and
tomerd
as code owners
|
@swift-ci please test |
|
@swift-ci please smoke test |
yim-lee
approved these changes
Aug 19, 2021
There was a problem hiding this comment.
Thanks @compnerd. How did you find this out? Does it cause problem for you?
Running the code locally, CCryptoBoringSSL_EVP_PKEY_id does seem to return the value we want (the function itself returns the key's type) and the tests pass, so this change LGTM.
|
@yim-lee a build error pointed me to the area of the code, the actual issue was found by inspection. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function takes a named argument which is the
EVP_PKEYand checksthe underlying public key type (expected to be one of RSA or EC).
However, instead of checking the key type of the given public key, it
was always returning the key type of the underlying certificate. This
happened to give the correct result as the current usage always used the
same object to get the key. This corrects that and uses the proper
accessors for the value.
[One line description of your change]
Motivation:
[Explain here the context, and why you're making that change. What is the problem you're trying to solve.]
Modifications:
[Describe the modifications you've done.]
Result:
[After your change, what will change.]