Improve swift-run failure mode #3685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case that you used `swift run`, and your executable failed to build, previously you would see this output, at the bottom of a potentially long list of warnings: ``` error: fatalError ``` In some cases, especially with lots of build output, this makes it look like your command ran, but your program failed, not the build. This silences that message, since the point of that error is that some other diagnostics should have been printed anyways.
keith
requested review from
abertelrud,
friedbunny,
neonichu and
tomerd
as code owners
neonichu
approved these changes
Aug 23, 2021
|
@swift-ci please smoke test |
|
I don't believe the failure here is related |
|
@swift-ci please smoke test |
tomerd
approved these changes
Aug 23, 2021
abertelrud
approved these changes
Aug 23, 2021
|
@swift-ci please smoke test |
|
Thanks! |
|
thank you @keith |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case that you used
swift run, and your executable failed tobuild, previously you would see this output, at the bottom of a
potentially long list of warnings:
In some cases, especially with lots of build output, this makes it look
like your command ran, but your program failed, not the build.
This silences that message, since the point of that error is that some
other diagnostics should have been printed anyways.