improve and relax the validation of explicit dependency names #3687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivation: follow up work to relaxing the requirement to set an explicit name on dependency, this relaxes the requirement that such name (if/when set) must match the manifest's name attribute, which we want to deprecate over time changes: * change the validation flow to ignore the name set in the manifest, instead manage an in-memory list of names used for target based pacakge lookup which suffices * remove a few tests that are no longer needed given the relaxed requirment * fix a couple of tests that were always wrong but previous validation did not catch
tomerd
requested review from
abertelrud,
friedbunny and
neonichu
as code owners
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
|
|
@swift-ci please smoke test linux |
neonichu
approved these changes
Aug 25, 2021
abertelrud
reviewed
Aug 25, 2021
abertelrud
approved these changes
Aug 25, 2021
|
Just wondering, is the goal to use the last path component of the package's url as the package name everywhere? |
|
@rauhul the goal is to make the name attribute in the manifest have no functional consequences, or iow make sure it is used for display only. this us a multi step process, and this PR brings us one step closer with SE-0292 we are transitioning to a reality where packages have unique identities, now these are derived from the url, but in the future they will be derived from a service |
|
@swift-ci please smoke test linux |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: follow up work to relaxing the requirement to set an explicit name on dependency, this relaxes the requirement that such name (if/when set) must match the manifest's name attribute, which we want to deprecate over time
changes: