Skip to content

Print reason for requiring resolution in verbose mode #3688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 2 additions & 49 deletions Sources/Commands/SwiftTool.swift
Original file line number Diff line number Diff line change
Expand Up @@ -148,56 +148,9 @@ private class ToolWorkspaceDelegate: WorkspaceDelegate {
guard isVerbose else { return }

queue.sync {
self.stdoutStream <<< "Running resolver because "

switch reason {
case .forced:
self.stdoutStream <<< "it was forced"
case .newPackages(let packages):
let dependencies = packages.lazy.map({ "'\($0.location)'" }).joined(separator: ", ")
self.stdoutStream <<< "the following dependencies were added: \(dependencies)"
case .packageRequirementChange(let package, let state, let requirement):
self.stdoutStream <<< "dependency '\(package.name)' was "

switch state {
case .checkout(let checkoutState)?:
switch checkoutState.requirement {
case .versionSet(.exact(let version)):
self.stdoutStream <<< "resolved to '\(version)'"
case .versionSet(_):
// Impossible
break
case .revision(let revision):
self.stdoutStream <<< "resolved to '\(revision)'"
case .unversioned:
self.stdoutStream <<< "unversioned"
}
case .edited?:
self.stdoutStream <<< "edited"
case .local?:
self.stdoutStream <<< "versioned"
case nil:
self.stdoutStream <<< "root"
}

self.stdoutStream <<< " but now has a "

switch requirement {
case .versionSet:
self.stdoutStream <<< "different version-based"
case .revision:
self.stdoutStream <<< "different revision-based"
case .unversioned:
self.stdoutStream <<< "unversioned"
}

self.stdoutStream <<< " requirement."
default:
self.stdoutStream <<< " requirements have changed."
}

self.stdoutStream <<< Workspace.format(workspaceResolveReason: reason)
self.stdoutStream <<< "\n"
stdoutStream.flush()
self.stdoutStream.flush()
}
}

Expand Down
60 changes: 57 additions & 3 deletions Sources/Workspace/Workspace.swift
Original file line number Diff line number Diff line change
Expand Up @@ -2033,11 +2033,13 @@ extension Workspace {
pinsStore: pinsStore
)

if precomputationResult.isRequired {
if case let .required(reason) = precomputationResult {
let reasonString = Self.format(workspaceResolveReason: reason)

if !fileSystem.exists(self.location.resolvedVersionsFile) {
diagnostics.emit(error: "a resolved file is required when automatic dependency resolution is disabled and should be placed at \(self.location.resolvedVersionsFile.pathString)")
diagnostics.emit(error: "a resolved file is required when automatic dependency resolution is disabled and should be placed at \(self.location.resolvedVersionsFile.pathString). \(reasonString)")
} else {
diagnostics.emit(error: "an out-of-date resolved file was detected at \(self.location.resolvedVersionsFile.pathString), which is not allowed when automatic dependency resolution is disabled; please make sure to update the file to reflect the changes in dependencies")
diagnostics.emit(error: "an out-of-date resolved file was detected at \(self.location.resolvedVersionsFile.pathString), which is not allowed when automatic dependency resolution is disabled; please make sure to update the file to reflect the changes in dependencies. \(reasonString)")
}
}

Expand Down Expand Up @@ -2814,6 +2816,58 @@ extension Workspace {
// Save the state.
try state.saveState()
}

public static func format(workspaceResolveReason reason: WorkspaceResolveReason) -> String {
var result = "Running resolver because "

switch reason {
case .forced:
result.append("it was forced")
case .newPackages(let packages):
let dependencies = packages.lazy.map({ "'\($0.location)'" }).joined(separator: ", ")
result.append("the following dependencies were added: \(dependencies)")
case .packageRequirementChange(let package, let state, let requirement):
result.append("dependency '\(package.name)' was ")

switch state {
case .checkout(let checkoutState)?:
switch checkoutState.requirement {
case .versionSet(.exact(let version)):
result.append("resolved to '\(version)'")
case .versionSet(_):
// Impossible
break
case .revision(let revision):
result.append("resolved to '\(revision)'")
case .unversioned:
result.append("unversioned")
}
case .edited?:
result.append("edited")
case .local?:
result.append("versioned")
case nil:
result.append("root")
}

result.append(" but now has a ")

switch requirement {
case .versionSet:
result.append("different version-based")
case .revision:
result.append("different revision-based")
case .unversioned:
result.append("unversioned")
}

result.append(" requirement.")
default:
result.append(" requirements have changed.")
}

return result
}
}

/// A result which can be loaded.
Expand Down
8 changes: 4 additions & 4 deletions Tests/WorkspaceTests/WorkspaceTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -3685,7 +3685,7 @@ final class WorkspaceTests: XCTestCase {
// Check force resolve. This should produce an error because the resolved file is out-of-date.
workspace.checkPackageGraphFailure(roots: ["Root"], forceResolvedVersions: true) { diagnostics in
DiagnosticsEngineTester(diagnostics) { result in
result.check(diagnostic: "an out-of-date resolved file was detected at /tmp/ws/Package.resolved, which is not allowed when automatic dependency resolution is disabled; please make sure to update the file to reflect the changes in dependencies", checkContains: true, behavior: .error)
result.check(diagnostic: "an out-of-date resolved file was detected at /tmp/ws/Package.resolved, which is not allowed when automatic dependency resolution is disabled; please make sure to update the file to reflect the changes in dependencies. Running resolver because requirements have changed.", checkContains: true, behavior: .error)
}
}
workspace.checkManagedDependencies { result in
Expand Down Expand Up @@ -3769,9 +3769,9 @@ final class WorkspaceTests: XCTestCase {
)

workspace.checkPackageGraphFailure(roots: ["Root"], forceResolvedVersions: true) { diagnostics in
DiagnosticsEngineTester(diagnostics) { result in
result.check(diagnostic: "a resolved file is required when automatic dependency resolution is disabled and should be placed at /tmp/ws/Package.resolved", checkContains: true, behavior: .error)
}
guard let diagnostic = diagnostics.diagnostics.first else { return XCTFail("unexpectedly got no diagnostics") }
// rdar://82544922 (`WorkspaceResolveReason` is non-deterministic)
XCTAssertTrue(diagnostic.message.text.hasPrefix("a resolved file is required when automatic dependency resolution is disabled and should be placed at /tmp/ws/Package.resolved. Running resolver because the following dependencies were added:"), "unexpected diagnostic message")
}
}

Expand Down