Do not generate a build parameters file if a custom one has been passed #3693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This already works, because it seems like the second `--buildParametersFile` option wins when invoking `xcbuild`, but it seems better to make this more explicit and more clean to not generate a file if the expectation is that it won't be used.
neonichu
requested review from
abertelrud,
friedbunny and
tomerd
as code owners
|
@swift-ci please smoke test |
|
Seeing the same test failure as in #3695
|
tomerd
approved these changes
Aug 28, 2021
abertelrud
approved these changes
Aug 30, 2021
|
@swift-ci please smoke test |
|
Looks as if this wasn't just flaky, |
tomerd
added
the
ready
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This already works, because it seems like the second
--buildParametersFileoption wins when invokingxcbuild, but it seems better to make this more explicit and more clean to not generate a file if the expectation is that it won't be used.