improve repository cache information emmited to delegate #3705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivation: fix flaky test, more accurate representaiton of cache usage information changes: * dont fail the cache lookup when the parent directory for the target is not found, create it instead * more reliabily report the status of when the repositories cache is updated and used * change the test to not rely on a side-effect of parent directory not being found, which is no longer the case * adjust the test to the new status reporting and add another step to test the behavior when cache is poopulated
tomerd
requested review from
abertelrud,
friedbunny and
neonichu
as code owners
|
@swift-ci please smoke test |
neonichu
approved these changes
Sep 1, 2021
tomerd
added
the
ready
mattt
pushed a commit
to mattt/swift-package-manager
that referenced
this pull request
Sep 16, 2021
) motivation: fix flaky test, more accurate representaiton of cache usage information changes: * dont fail the cache lookup when the parent directory for the target is not found, create it instead * more reliabily report the status of when the repositories cache is updated and used * change the test to not rely on a side-effect of parent directory not being found, which is no longer the case * adjust the test to the new status reporting and add another step to test the behavior when cache is poopulated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: fix flaky test, more accurate representaiton of cache usage information
changes: