New name for "disable automatic resolution" #3706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new alias for this flag and also updates the help text. Previous names of the flag will continue to work as well. rdar://81961772
neonichu
requested review from
abertelrud,
friedbunny and
tomerd
as code owners
|
@swift-ci please smoke test |
abertelrud
approved these changes
Sep 2, 2021
tomerd
approved these changes
Sep 2, 2021
kimdv
approved these changes
Sep 2, 2021
tomerd
reviewed
Sep 2, 2021
|
|
||
| /// Use Package.resolved file for resolving dependencies. | ||
| @Flag(name: [.long, .customLong("disable-automatic-resolution")], help: "Disable automatic resolution if Package.resolved file is out-of-date") | ||
| @Flag(name: [.long, .customLong("disable-automatic-resolution"), .customLong("only-use-versions-from-resolved-file")], help: "Only use versions from the Package.resolved file and fail resolution if it is out-of-date") |
There was a problem hiding this comment.
should we also add a deprecation warning when using the old flag to encourage folks to transition over? or at least adda comment here to say which one is "preferred"
There was a problem hiding this comment.
Not sure we can know which of the flags was used, maybe @natecook1000 has an idea how to do that without splitting it out into multiple flags.
mattt
pushed a commit
to mattt/swift-package-manager
that referenced
this pull request
Sep 16, 2021
This adds a new alias for this flag and also updates the help text. Previous names of the flag will continue to work as well. rdar://81961772
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new alias for this flag and also updates the help text. Previous names of the flag will continue to work as well.
rdar://81961772