fix potential race in the computation of cache state #3711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivation: fix unstable test changes: compute the cache state before queueing the delegate call, since otherwise it may compute the state after the cache has been created
tomerd
requested review from
abertelrud,
friedbunny and
neonichu
as code owners
|
@swift-ci please smoke test |
tomerd
added
the
ready
abertelrud
approved these changes
Sep 3, 2021
neonichu
approved these changes
Sep 3, 2021
mattt
pushed a commit
to mattt/swift-package-manager
that referenced
this pull request
Sep 16, 2021
motivation: fix unstable test changes: compute the cache state before queueing the delegate call, since otherwise it may compute the state after the cache has been created
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: fix unstable test
changes: compute the cache state before queueing the delegate call, since otherwise it may compute the state after the cache has been created