improve error message when Package.resolved cannot be loaded #3721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
requested review from
abertelrud,
friedbunny and
neonichu
as code owners
|
needs #3717 first |
tomerd
force-pushed
the
fix/serialization-error-message
branch
2 times, most recently
from
05753f8 to
385eeb8
Compare
|
@swift-ci please smoke test |
tomerd
added
the
ready
neonichu
approved these changes
Sep 7, 2021
tomerd
force-pushed
the
fix/serialization-error-message
branch
from
385eeb8 to
1752166
Compare
|
@swift-ci please smoke test |
abertelrud
reviewed
Sep 7, 2021
abertelrud
approved these changes
Sep 7, 2021
tomerd
force-pushed
the
fix/serialization-error-message
branch
from
1752166 to
7e28c6b
Compare
motivation: provide clear and actionable information when trying to load pacakge.resolved file from a non-supported version, or otherwise malformed. changes: * add contextual information to error message * add few tests
tomerd
force-pushed
the
fix/serialization-error-message
branch
from
7e28c6b to
1585f67
Compare
|
@swift-ci please smoke test |
tomerd
force-pushed
the
fix/serialization-error-message
branch
from
1585f67 to
8b2a406
Compare
|
@swift-ci please smoke test |
tomerd
force-pushed
the
fix/serialization-error-message
branch
from
8b2a406 to
ed46762
Compare
|
@swift-ci please smoke test |
mattt
pushed a commit
to mattt/swift-package-manager
that referenced
this pull request
Sep 16, 2021
…ng#3721) * improve error message when Package.resolved cannot be loaded motivation: provide clear and actionable information when trying to load pacakge.resolved file from a non-supported version, or otherwise malformed. changes: * add contextual information to error message * add few tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: provide clear and actionable information when trying to load pacakge.resolved file from a non-supported version, or otherwise malformed.
changes: