Force-unwrap an optional so we print the value without Optional("..."). #376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -303,7 +303,7 @@ enum CleanMode: CustomStringConvertible { | |||
| case "dist"?, "distribution"?: | |||
| self = .dist | |||
| default: | |||
| throw OptionParserError.invalidUsage("invalid clean mode: \(rawValue)") | |||
| throw OptionParserError.invalidUsage("invalid clean mode: \(rawValue!)") | |||
There was a problem hiding this comment.
wouldn't rawValue ?? "nil" be better in case someone ends up removing nil from switch case
|
Thanks Mark! Landed alternate version in b4c7c98 |
aciidgh
pushed a commit
to aciidgh/swift-package-manager
that referenced
this pull request
Jan 11, 2019
Merge coding additions from swiftlang#189
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix for an issue I noticed while using swift-build --clean.