Add conformance of an enum to String so that SwiftPM still builds on 5.4 #3760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abertelrud
requested review from
friedbunny,
neonichu and
tomerd
as code owners
|
@swift-ci please smoke test |
abertelrud
force-pushed
the
eng/fix-break-on-swiftpm-5.4
branch
from
63093fc to
5bdd16b
Compare
|
@swift-ci please smoke test |
tomerd
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
#3712 accidentally made SwiftPM no longer compile using 5.4, which lacks automatic Codable synthesis for enums.
Modifications:
Make
PluginActionin the PackagePlugin API conform toStringas well asDecodable.Result:
SwiftPM can build on 5.4.