make error message more specific when failing to create build system with LLBuild #3761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
requested review from
abertelrud,
friedbunny and
neonichu
as code owners
tomerd
force-pushed
the
fix/improve-error-message
branch
from
319ea9c to
5078fcc
Compare
…with LLBuild motivation: clearer error message to help diagnose when LLBuild fails changes: instead of throwing a generic error, throw a more detailed one
tomerd
force-pushed
the
fix/improve-error-message
branch
from
5078fcc to
1e0b777
Compare
|
@swift-ci please smoke test |
abertelrud
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: clearer error message to help diagnose when LLBuild fails
changes: instead of throwing a generic error, throw a more detailed one