Skip to content

rename LLBuild manifest builder to LLBuildManifestBuilder #3771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2021
Merged

rename LLBuild manifest builder to LLBuildManifestBuilder #3771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/Build/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ add_library(Build
BuildOperationBuildSystemDelegateHandler.swift
BuildOperation.swift
BuildPlan.swift
ManifestBuilder.swift
LLBuildManifestBuilder.swift
SPMSwiftDriverExecutor.swift
SwiftCompilerOutputParser.swift)
target_link_libraries(Build PUBLIC
Expand Down
12 changes: 5 additions & 7 deletions Sources/Build/ManifestBuilder.swift → Sources/Build/LLBuildManifestBuilder.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,9 @@ public class LLBuildManifestBuilder {
}
}

// MARK:- Package Structure
// MARK: - Package Structure

extension LLBuildManifestBuilder {

fileprivate func addPackageStructureCommand() {
let inputs = plan.graph.rootPackages.flatMap { package -> [Node] in
var inputs = package.targets
Expand Down Expand Up @@ -136,7 +135,6 @@ extension LLBuildManifestBuilder {
// MARK:- Binary Dependencies

extension LLBuildManifestBuilder {

// Creates commands for copying all binary artifacts depended on in the plan.
fileprivate func addBinaryDependencyCommands() {
let binaryPaths = Set(plan.targetMap.values.flatMap({ $0.libraryBinaryPaths }))
Expand All @@ -147,7 +145,7 @@ extension LLBuildManifestBuilder {
}
}

// MARK:- Resources Bundle
// MARK: - Resources Bundle

extension LLBuildManifestBuilder {
/// Adds command for creating the resources bundle of the given target.
Expand Down Expand Up @@ -633,7 +631,7 @@ extension LLBuildManifestBuilder {
}
}

// MARK:- Compile C-family
// MARK: - Compile C-family

extension LLBuildManifestBuilder {
/// Create a llbuild target for a Clang target description.
Expand Down Expand Up @@ -777,7 +775,7 @@ extension LLBuildManifestBuilder {
}
}

// MARK:- Product Command
// MARK: - Product Command

extension LLBuildManifestBuilder {
private func createProductCommand(_ buildProduct: ProductBuildDescription) throws {
Expand Down Expand Up @@ -859,7 +857,7 @@ extension ResolvedProduct {
}
}

// MARK:- Helper
// MARK: - Helper

extension LLBuildManifestBuilder {
@discardableResult
Expand Down