restore TSC Diagnostic location behavior #3792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
requested review from
abertelrud,
friedbunny and
neonichu
as code owners
tomerd
force-pushed
the
fix/diagnostics-location
branch
from
acad2f5 to
80d3dec
Compare
|
@swift-ci please smoke test |
abertelrud
approved these changes
Oct 6, 2021
motivation: downstream clients still depend on TSC Diagnostics Location changes: * preserve original TSC Location in metadata and bridge it back when exposing TSC diagnostics * adjust test
tomerd
force-pushed
the
fix/diagnostics-location
branch
from
80d3dec to
c34839a
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
neonichu
approved these changes
Oct 6, 2021
|
@swift-ci please smoke test |
tomerd
force-pushed
the
fix/diagnostics-location
branch
from
864cf19 to
ecd58cf
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: downstream clients still depend on TSC Diagnostic location and data
changes: