use verbosity flags to drive diagnostics logging level #3809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
requested review from
abertelrud,
friedbunny and
neonichu
as code owners
|
@swift-ci please smoke test |
tomerd
added
the
ready
neonichu
approved these changes
Oct 26, 2021
motivation: allow users to specify verbosity which would impact how much diagnostic information is outputed changes: * add "very-verbose" CLI flag * drive diagnostics logging level based on verbosity flags: verbose == .info, very-verbose == .debug * filter diagnostic printing based on log level * pass logLevel where appropriate instead of isVerbose * add test
tomerd
force-pushed
the
diagnostics-verbosity
branch
from
b2c31a7 to
7b02188
Compare
|
@swift-ci please smoke test |
|
@neonichu @abertelrud @elsh @yim-lee with this change in, we can now make use of emitting "info" and "debug" information more liberally since it will be filtered out in the output unless run in verbose or very-verbose modes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: allow users to specify verbosity which would impact how much diagnostic information is outputed
changes: