save Package.resolved with a trailing newline #3822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivation: we lost the trailing newline when moving to COdable based encoder changes: add trailing newline in POSIXy systems rdar://83646952
tomerd
requested review from
abertelrud,
friedbunny and
neonichu
as code owners
|
@swift-ci please smoke test |
tomerd
added
the
ready
abertelrud
reviewed
Oct 28, 2021
| if toolsVersion >= .v5_6 { | ||
| let container = try V2(pins: pins, mirrors: mirrors) | ||
| data = try self.encoder.encode(container) | ||
| } else { | ||
| let container = try V1(pins: pins, mirrors: mirrors) | ||
| data = try self.encoder.encode(container) | ||
| } | ||
| #if !os(Windows) |
There was a problem hiding this comment.
Is there a reason the Windows one shouldn't add with \r\n?
There was a problem hiding this comment.
we could, but i am not sure if a trailing newline is a convention on Windows
There was a problem hiding this comment.
Good point — anyway it doesn't make a lot of difference provided that they work fine there without it. No reason not to merge, it would just be nicer to avoid the #if if there was a stock way of appending a platform line separator.
abertelrud
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: we lost the trailing newline when moving to COdable based encoder
changes: add trailing newline in POSIXy systems
rdar://83646952