[5.5] Add support for correctly discovering async test methods on non-Apple platforms #3861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… platforms. * Update `TestDiscoveryCommand` to wrap async test methods in `asyncTest` function calls. * Add integration test * Adapt to the latest s-t-s-c modeling adjustments.
briancroom
requested review from
abertelrud,
friedbunny,
neonichu and
tomerd
as code owners
tomerd
approved these changes
Nov 11, 2021
|
@briancroom does this need cross repo test? |
stmontgomery
approved these changes
Nov 11, 2021
|
@briancroom is this ready to be merged? |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
We need to first merge swiftlang/swift-corelibs-xctest#335 which was unblocked this afternoon! |
|
@swift-ci please test |
|
Looking good! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nominating the changes from #3844 to be pulled back for a 5.5.x dot release.