Improve Resolver Determinism #3862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDGGiesbrecht
requested review from
abertelrud,
elsh,
neonichu and
tomerd
as code owners
11 tasks
|
@swift-ci please smoke test |
tomerd
approved these changes
Nov 11, 2021
neonichu
approved these changes
Nov 12, 2021
|
Thank you @SDGGiesbrecht, this is great! Might seem like a small thing but I think it can help understandability in a subtle way. |
abertelrud
approved these changes
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spun out of #3838. This makes sure the order of resolution diagnostics is deterministic.
Unlike the first iteration in #3838, this does it properly and preserves the user’s order (which turned out to be much easier than I expected). It also adds a test that would catch any regression, regardless of the resolution mode.