Package registry client #3864
Merged
Package registry client #3864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yim-lee
requested review from
abertelrud,
elsh,
neonichu and
tomerd
as code owners
|
@swift-ci please smoke test |
tomerd
reviewed
Nov 12, 2021
|
@swift-ci please smoke test |
tomerd
approved these changes
Nov 12, 2021
| @@ -77,43 +87,46 @@ public final class RegistryManager { | |||
| method: .get, | |||
| url: url, | |||
| headers: [ | |||
| "Accept": "application/vnd.swift.registry.v1+json" | |||
| "Accept": self.acceptHeader(mediaType: .json), | |||
| completion: @escaping (Result<Manifest, Error>) -> Void | ||
| ) { | ||
| guard case let (scope, name)? = package.identity.scopeAndName else { | ||
| let completion = self.makeAsync(completion, on: callbackQueue) |
|
ci failures should be solved with #3865 |
|
@swift-ci please smoke test |
Continue swiftlang#3640 and polish up the registry client.
yim-lee
force-pushed
the
registry-client
branch
from
8107da7 to
54cee0a
Compare
|
@swift-ci please smoke test |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue #3640 and
polish up the registry client.