Skip to content

state file parsing errors should not assert #3865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2021
Merged

state file parsing errors should not assert #3865

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Sources/Workspace/WorkspaceState.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ extension WorkspaceStateStorage {
let path = try container.decode(AbsolutePath?.self, forKey: .path)
return try self.init(underlying: .edited(basedOn: basedOn.map { try .init($0) }, unmanagedPath: path))
default:
throw InternalError("unknown checkout state \(kind)")
throw StringError("unknown dependency state \(kind)")
}
}

Expand Down Expand Up @@ -318,7 +318,7 @@ extension WorkspaceStateStorage {
let checksum = try container.decode(String.self, forKey: .checksum)
self.init(underlying: .remote(url: url, checksum: checksum))
default:
throw InternalError("unknown checkout state \(kind)")
throw StringError("unknown artifact source \(kind)")
}
}

Expand Down Expand Up @@ -518,7 +518,7 @@ extension WorkspaceStateStorage {
let path = try container.decode(AbsolutePath?.self, forKey: .path)
return try self.init(underlying: .edited(basedOn: basedOn.map { try .init($0) }, unmanagedPath: path))
default:
throw InternalError("unknown checkout state \(kind)")
throw StringError("unknown dependency state \(kind)")
}
}

Expand Down Expand Up @@ -578,7 +578,7 @@ extension WorkspaceStateStorage {
let checksum = try container.decode(String.self, forKey: .checksum)
self.init(underlying: .remote(url: url, checksum: checksum))
default:
throw InternalError("unknown checkout state \(kind)")
throw StringError("unknown artifact source \(kind)")
}
}

Expand Down