Activate Disabled Tests #3870
Activate Disabled Tests #3870
Conversation
SDGGiesbrecht
requested review from
abertelrud,
elsh,
neonichu and
tomerd
as code owners
|
I may have disabled them because they relied on test-only dependencies working which was originally behind |
|
@swift-ci please smoke test |
| } else { | ||
| return nil | ||
| } | ||
| } |
There was a problem hiding this comment.
not sure about this mutating subscript. why does it need to mutate?
There was a problem hiding this comment.
The subscript simply follows the pattern of the others around it, filling the hole for this particular signature:
- Existing:
subscript(_ key: SingleValueSetting) -> String? - Added because missing:
subscript(_ key: SingleValueSetting, for platform: Platform) -> String? - Existing:
subscript(_ key: MultipleValueSetting) -> [String]? - Existing:
subscript(_ key: MultipleValueSetting, for platform: Platform) -> [String]?
The tests that call these subscripts appear to expect each call to clear the respective entry. After all expected settings have been checked (removing them as a side effect), the tests then check that the remainder is indeed empty. Left over entries (due to the list having gone stale) were why the test had been failing. Some of the entries I needed to add had this signature, which was not yet supported by the existing subscripts.
Spun out of #3838.
Either these tests were only mistakenly disabled behind
ENABLE_TARGET_BASED_DEPENDENCY_RESOLUTIONin the first place, or else the reason for their disabling has since evaporated.The PIF tests had gone stale and missed some some identifier and setting updates, so those have been repaired.
(I did also update one identifier that is still behind a disabling condition. Otherwise it would have been the only stale PIF identifier left, and it seemed like it belonged together with all the PIF identifiers.)