-
Notifications
You must be signed in to change notification settings - Fork 1.4k
integrate registry dependencies into dependency resolution #3873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -65,14 +65,14 @@ public struct PackageIdentity: CustomStringConvertible { | |
} | ||
|
||
// TODO: formalize package registry identifier | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unrelated to this PR: is this done? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would need to take another look. will address in follow up PR of needs more attention, it works fine for the test cases I ran |
||
public var scopeAndName: (Scope, Name)? { | ||
public var scopeAndName: (scope: Scope, name: Name)? { | ||
let components = description.split(separator: ".", maxSplits: 1, omittingEmptySubsequences: true) | ||
guard components.count == 2, | ||
let scope = Scope(components.first), | ||
let name = Name(components.last) | ||
else { return nil } | ||
else { return .none } | ||
|
||
return (scope, name) | ||
return (scope: scope, name: name) | ||
} | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Safer to do case-insensitive compare