Skip to content

Increment SwiftPM tools version to 5.5 and minimum deployment target to 10.15.4 on macOS #3875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

abertelrud
Copy link
Contributor

Increment SwiftPM tools version to 5.5 and minimum deployment target to 10.15.4 on macOS

Motivation:

Allow use of Swift 5.5 features such as automatic Codable synthesis. Minimum deployment target of 10.15.4 allows use of FileHandle improvements such as read(upToCount:).

… allow use of Swift-friendlier FileHandle APIs, so we can minimize use of stdio.
Motivation: Allow use of 5.5 features such as automatic Codable synthesis.
@abertelrud abertelrud added the ready Author believes the PR is ready to be merged & any feedback has been addressed label Nov 18, 2021
@abertelrud
Copy link
Contributor Author

@swift-ci please smoke test

@abertelrud
Copy link
Contributor Author

@benlangmuir would it be possible also for SourceKit-LSP to require 10.15.4 on macOS? Seems like a small change compared with 10.15, and the reason was to allow the new Swift-friendlier FileHandle APIs (that throw Swift.Errors instead of raising ObjC exceptions).

I can open a SourceKit-LSP PR if that isn't a no-go.

@benlangmuir
Copy link
Contributor

@benlangmuir would it be possible also for SourceKit-LSP to require 10.15.4 on macOS? Seems like a small change compared with 10.15, and the reason was to allow the new Swift-friendlier FileHandle APIs (that throw Swift.Errors instead of raising ObjC exceptions).

No concerns from me, we've generally bumped our deployment target whenever swiftpm decides to, I think. CCing @akyrtzi and @ahoppen in case they want to protest.

@akyrtzi
Copy link
Contributor

akyrtzi commented Nov 18, 2021

We can follow swiftpm on this, I don't have any concern.

@abertelrud
Copy link
Contributor Author

Great, thanks all for the comments.

@abertelrud
Copy link
Contributor Author

swiftlang/sourcekit-lsp#436
@swift-ci please smoke test

@abertelrud abertelrud self-assigned this Nov 18, 2021
@abertelrud abertelrud merged commit 2509112 into swiftlang:main Nov 19, 2021
@abertelrud abertelrud deleted the eng/increment-toolsversion-and-deploymentversion branch December 27, 2021 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Author believes the PR is ready to be merged & any feedback has been addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants