Enable Target‐Based Resolution #3880
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDGGiesbrecht
requested review from
abertelrud,
elsh,
neonichu and
tomerd
as code owners
|
@swift-ci please smoke test |
|
@swift-ci please test package compatibility |
|
@SDGGiesbrecht iiuc merging this will enable the feature, correct? If so, I'd like to take it some time next week or so and see how it holds. does that work for you? |
|
Yes, that is correct. And yes, you can take whatever time you need. Feel free to ping me if you discover any other issues. (I haven’t looked at it since the package registry–resolution tie‐in work was merged.) |
tomerd
added
the
ready
|
@swift-ci please smoke test |
|
@swift-ci please test package compatibility |
11 tasks
|
Closing. This and related PRs are stale and I do not have time to maintain them anymore. I will leave the related branches around for now in case anyone else wants to pick them up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last piece of #3838 that actually turns target‐based resolution on by default. It is just a few lines in the manifest in order to be easy to revert if problems arise again.
This applies
ENABLE_TARGET_BASED_DEPENDENCY_RESOLUTIONto every target.If needed for debugging, it can still be temporarily disabled during development by either setting
DISABLE_TARGET_BASED_DEPENDENCY_RESOLUTIONin the environment or by commenting out this bit of the manifest, whichever is more convenient at any given time.At a later date, if everything has gone smoothly for a while, then all references to the compilation condition can be removed.