Load manifests asynchronously #3894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcbeard
requested review from
abertelrud,
elsh,
neonichu and
tomerd
as code owners
|
@swift-ci please smoke test |
|
@pcbeard @abertelrud how about we let all the other changes time (couple of days) to propagate through the system then merge this? |
|
@tomerd Sounds like a good plan. |
pcbeard
force-pushed
the
AsyncManifestLoading2
branch
from
5f6a6df to
81c1d6e
Compare
|
@swift-ci please smoke test |
tomerd
added
the
ready
DelayableAction represents an action on a target that can be deferred until a more appropriate time. In this case, we use defer to cleanup objects in the case of early return error handling, but we need to delay this action when passing the target for use into an async completion block.
The manifest parser uses SourceControl.GitShellHelper synchronously, which would cause a hang if using the default queue for completions.
This is required for unit tests to pass.
pcbeard
force-pushed
the
AsyncManifestLoading2
branch
from
81c1d6e to
921f9c0
Compare
|
@swift-ci please smoke test |
tomerd
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3872 for full description.
This adds one more commit, to remove a throws from the evaluateManifest() method.