Skip to content

preserve old formatting of Package.resolved in tools-version < 5.6 #3931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2021

Conversation

tomerd
Copy link
Contributor

@tomerd tomerd commented Dec 10, 2021

motivation: We moved to JSONEncoder in 5.6 which formats JSON in a non-traditional way (add space around the field name colon), and different from previous version of SwiftPM. We can make the change tools-version dependent.

changes: user older JSON encoder when tools-version < 5.6, preserving previous format

rdar://86341850

motivation: We moved to JSONEncoder in 5.6 which formats JSON in a non-traditional way (add space around the field name colon), and different from previous version of SwiftPM. We can make the change tools-version dependent.

changes: user older JSON encoder when tools-version < 5.6, preserving previous format

rdar://86341850
@tomerd
Copy link
Contributor Author

tomerd commented Dec 10, 2021

@swift-ci please smoke test

@tomerd tomerd added the ready Author believes the PR is ready to be merged & any feedback has been addressed label Dec 10, 2021
@tomerd tomerd merged commit 7b8b322 into swiftlang:main Dec 13, 2021
tomerd added a commit to tomerd/swift-package-manager that referenced this pull request Dec 13, 2021
…wiftlang#3931)

motivation: We moved to JSONEncoder in 5.6 which formats JSON in a non-traditional way (add space around the field name colon), and different from previous version of SwiftPM. We can make the change tools-version dependent.

changes: user older JSON encoder when tools-version < 5.6, preserving previous format

rdar://86341850
tomerd added a commit that referenced this pull request Dec 15, 2021
…3931) (#3939)

motivation: We moved to JSONEncoder in 5.6 which formats JSON in a non-traditional way (add space around the field name colon), and different from previous version of SwiftPM. We can make the change tools-version dependent.

changes: user older JSON encoder when tools-version < 5.6, preserving previous format

rdar://86341850
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Author believes the PR is ready to be merged & any feedback has been addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants