reduce concurrent manifest loading test contention #3954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivation: with manfiest loading async, the concurrent loading tests introduce significant contention on cpu since the underlying queue in unbounded changes: use semaphore to limit the concurrency to max active cpus
|
cc @pcbeard |
|
@swift-ci please smoke test |
tomerd
added
the
ready
abertelrud
approved these changes
Dec 17, 2021
|
This problem being fixed here only affects |
at this point yes, #3940 will bring async manifest loading into 5.6 |
pcbeard
pushed a commit
to pcbeard/swift-package-manager
that referenced
this pull request
Dec 22, 2021
motivation: with manfiest loading async, the concurrent loading tests introduce significant contention on cpu since the underlying queue in unbounded changes: use semaphore to limit the concurrency to max active cpus
tomerd
pushed a commit
that referenced
this pull request
Dec 23, 2021
* Refactor manifest loading to use new async Process.popen() * Use DelayableAction to ensure deferred actions are managed correctly DelayableAction represents an action on a target that can be deferred until a more appropriate time. In this case, we use defer to cleanup objects in the case of early return error handling, but we need to delay this action when passing the target for use into an async completion block. * Use delegateQueue to avoid reusing the TSCBasic.Process default queue The manifest parser uses SourceControl.GitShellHelper synchronously, which would cause a hang if using the default queue for completions. * reduce concurrent manifest loading test contention (#3954) motivation: with manfiest loading async, the concurrent loading tests introduce significant contention on cpu since the underlying queue in unbounded changes: use semaphore to limit the concurrency to max active cpus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: with manfiest loading async, the concurrent loading tests introduce significant contention on cpu since the underlying queue in unbounded
changes: use semaphore to limit the concurrency to max active cpus