avoid deprecation warnings from test discovery #3992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivation: do not prduce warning when tests are marked as deprecated, since they are designed to test deprecated functionality changes: * mark generated test-discovery wrappers as psuedo-deprecated so they dont produce deprecation warnings * use @main for the test discovery entry point instead of main.swift which helps avoid deprecation warnings at the entry point * cleanup test discovery generate names to be easier to reason about * add and adjust tests for throwing variants * add test for deprecation use case
|
@swift-ci please smoke test |
|
@Lukasa iirc you filed a jira/radar on this? could not find it! do you happen to have a link so I can associate with the fix? |
tomerd
added
the
ready
abertelrud
approved these changes
Jan 8, 2022
tomerd
added a commit
to tomerd/swift-package-manager
that referenced
this pull request
Jan 8, 2022
motivation: small follow up cleanup to swiftlang#3992 which consolidates the use of a share defintiion for the main file used for test discovery changes: use the shared defintiion for the main file name used for test discovery everywhere
tomerd
added a commit
to tomerd/swift-package-manager
that referenced
this pull request
Jan 8, 2022
motivation: do not prduce warning when tests are marked as deprecated, since they are designed to test deprecated functionality changes: * mark generated test-discovery wrappers as psuedo-deprecated so they dont produce deprecation warnings * use @main for the test discovery entry point instead of main.swift which helps avoid deprecation warnings at the entry point * cleanup test discovery generate names to be easier to reason about * add and adjust tests for throwing variants * add test for deprecation use case
tomerd
added a commit
that referenced
this pull request
Jan 9, 2022
motivation: small follow up cleanup to #3992 which consolidates the use of a share defintiion for the main file used for test discovery changes: use the shared defintiion for the main file name used for test discovery everywhere
tomerd
added a commit
to tomerd/swift-package-manager
that referenced
this pull request
Jan 9, 2022
motivation: small follow up cleanup to swiftlang#3992 which consolidates the use of a share defintiion for the main file used for test discovery changes: use the shared defintiion for the main file name used for test discovery everywhere
tomerd
added a commit
that referenced
this pull request
Jan 9, 2022
motivation: do not prduce warning when tests are marked as deprecated, since they are designed to test deprecated functionality changes: * mark generated test-discovery wrappers as psuedo-deprecated so they dont produce deprecation warnings * use @main for the test discovery entry point instead of main.swift which helps avoid deprecation warnings at the entry point * cleanup test discovery generate names to be easier to reason about * add and adjust tests for throwing variants * add test for deprecation use case
tomerd
added a commit
that referenced
this pull request
Jan 9, 2022
motivation: small follow up cleanup to #3992 which consolidates the use of a share defintiion for the main file used for test discovery changes: use the shared defintiion for the main file name used for test discovery everywhere
|
Sorry for the delay, @weissi filed the issue: https://bugs.swift.org/browse/SR-12008. |
glbrntt
added a commit
to glbrntt/swift-package-manager
that referenced
this pull request
Mar 17, 2022
Motivation: In swiftlang#3992 the class name was stripped from the static array of tests (i.e. `__allTests_CLASSNAME` became `__allTests`). The class name ensured the variable was uniquely named. Without it, in a test class which is derived from another, it is not unique and results in compile-time errors. Modifications: - Reintroduce the class name - Add tests Result: Dervied test classes do not result in compilation errors on Linux.
glbrntt
added a commit
to glbrntt/swift-package-manager
that referenced
this pull request
Mar 17, 2022
Motivation: In swiftlang#3992 the class name was stripped from the static array of tests (i.e. `__allTests_CLASSNAME` became `__allTests`). The class name ensured the variable was uniquely named. Without it, in a test class which is derived from another, it is not unique and results in compile-time errors. Modifications: - Reintroduce the class name - Add tests Result: Dervied test classes do not result in compilation errors on Linux.
tomerd
pushed a commit
that referenced
this pull request
Mar 17, 2022
Motivation: In #3992 the class name was stripped from the static array of tests (i.e. `__allTests_CLASSNAME` became `__allTests`). The class name ensured the variable was uniquely named. Without it, in a test class which is derived from another, it is not unique and results in compile-time errors. Modifications: - Reintroduce the class name - Add tests Result: Dervied test classes do not result in compilation errors on Linux.
glbrntt
added a commit
to glbrntt/swift-package-manager
that referenced
this pull request
Mar 18, 2022
Motivation: In swiftlang#3992 the class name was stripped from the static array of tests (i.e. `__allTests_CLASSNAME` became `__allTests`). The class name ensured the variable was uniquely named. Without it, in a test class which is derived from another, it is not unique and results in compile-time errors. Modifications: - Reintroduce the class name - Add tests Result: Dervied test classes do not result in compilation errors on Linux.
glbrntt
added a commit
to glbrntt/swift-package-manager
that referenced
this pull request
Mar 18, 2022
Motivation: In swiftlang#3992 the class name was stripped from the static array of tests (i.e. `__allTests_CLASSNAME` became `__allTests`). The class name ensured the variable was uniquely named. Without it, in a test class which is derived from another, it is not unique and results in compile-time errors. Modifications: - Reintroduce the class name - Add tests Result: Dervied test classes do not result in compilation errors on Linux. (cherry picked from commit 27cd3df)
glbrntt
added a commit
that referenced
this pull request
Mar 23, 2022
Motivation: In #3992 the class name was stripped from the static array of tests (i.e. `__allTests_CLASSNAME` became `__allTests`). The class name ensured the variable was uniquely named. Without it, in a test class which is derived from another, it is not unique and results in compile-time errors. Modifications: - Reintroduce the class name - Add tests Result: Dervied test classes do not result in compilation errors on Linux. (cherry picked from commit 27cd3df)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: do not prduce warning when tests are marked as deprecated, since they are designed to test deprecated functionality
changes: