gracefully handle pre-existing binary artifact from failed downloads #4021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivation: when binary artifact download fails it may leave behind a partial or otherwise corrupt file changes: * remove pre-existing archive file before attempting to download the same file again * add test
|
@swift-ci please smoke test |
tomerd
added
the
ready
abertelrud
reviewed
Jan 14, 2022
| func testArtifactDownloadArchiveExists() throws { | ||
| let sandbox = AbsolutePath("/tmp/ws/") | ||
| let fs = InMemoryFileSystem() | ||
| // this relies on internal knowledge of the destination path construction |
There was a problem hiding this comment.
This seems fine for a unit test. We could always extract into a static property for the subpath if we feel it's important enough.
abertelrud
approved these changes
Jan 14, 2022
tomerd
added a commit
to tomerd/swift-package-manager
that referenced
this pull request
Jan 14, 2022
…wiftlang#4021) motivation: when binary artifact download fails it may leave behind a partial or otherwise corrupt file changes: * remove pre-existing archive file before attempting to download the same file again * add test
tomerd
requested review from
airspeedswift
and removed request for
airspeedswift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: when binary artifact download fails it may leave behind a partial or otherwise corrupt file
changes: