Remove unnecessary TSCLibc dependency
#4073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
requested review from
abertelrud,
elsh,
neonichu and
tomerd
as code owners
|
@swift-ci please smoke test |
tomerd
approved these changes
Feb 1, 2022
|
@swift-ci please smoke test |
neonichu
approved these changes
Feb 1, 2022
Remove the `TSCLibc` dependency as we do not depend on any of the interfaces from the module. This matters particularly on Windows where static linking Swift content is not available, so this will reduce the amount of dirty memory due to the dynamic library link that cannot be removed.
|
@swift-ci please test |
|
@swift-ci please smoke test |
abertelrud
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
TSCLibcdependency as we do not depend on any of theinterfaces from the module. This matters particularly on Windows
where static linking Swift content is not available, so this will
reduce the amount of dirty memory due to the dynamic library link
that cannot be removed.
[One line description of your change]
Motivation:
[Explain here the context, and why you're making that change. What is the problem you're trying to solve.]
Modifications:
[Describe the modifications you've done.]
Result:
[After your change, what will change.]