improve handling of redundant output on stdout for commands that emit consumable information #4118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
changed the title
tomerd
force-pushed
the
radar/78612028
branch
from
d12f3cd to
630f666
Compare
… consumable information motvation: some CLI command emit consumable informaiton such as json. in those case we dont want to include any other information on stdout, so that it can be consumed by pipes changes: * for the following commands: * swift package dump-package * swift package dump-pif * swift package describe * swift package experimental-api-diff * swift package show-dependencies * swift test --list * redirect stdout to stderr prior to calling other actions * adjust result printing to always use stdout * adjust tests rdar://78612028
tomerd
force-pushed
the
radar/78612028
branch
from
630f666 to
40e2fd9
Compare
tomerd
added
the
ready
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
@swift-ci smoke test linux |
|
It's an existing function and might just be me, but I find the name |
neonichu
approved these changes
Feb 10, 2022
good point. planning to make more changes in this area, including dealing with this function so will handle it then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motvation: some CLI command emit consumable informaiton such as json. in those case we dont want to include any other information on stdout, so that it can be consumed by pipes
changes:
rdar://78612028