improve example created by package init --type executable #4122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
force-pushed
the
radar/82119401
branch
from
cce03c7 to
7d1602e
Compare
|
@swift-ci please smoke test |
tomerd
added
the
ready
neonichu
approved these changes
Feb 11, 2022
|
Looks like maybe what we're doing here isn't supported in the older toolchain used for self-hosted tests? The error messages are a bit confusing to me. |
tomerd
force-pushed
the
radar/82119401
branch
from
7d1602e to
b418ed2
Compare
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
motivation: example is out of date with best practices changes: * use @main istead of main.swift * test executable directly instead of shelling out to a process * adjust tests rdar://82119401
tomerd
force-pushed
the
radar/82119401
branch
from
591e2a7 to
274d94e
Compare
|
@swift-ci please smoke test |
tomerd
force-pushed
the
radar/82119401
branch
from
274d94e to
0958026
Compare
|
@swift-ci please smoke test |
shahmishal
added a commit
that referenced
this pull request
Feb 12, 2022
)" This reverts commit 85a84d9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: example is out of date with best practices
changes:
rdar://82119401