Skip to content

improve registry client handling of alternative locations #4142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

tomerd
Copy link
Contributor

@tomerd tomerd commented Feb 16, 2022

motication: preparation work for mixed graphs

changes:

  • rename RegistryClient::listVersions API to getPackageMetadata and revise it to parse the link header that contains the alternative URLs for the package
  • enhance RegistryClient::getIdentifers API to use codable for parsing the server result
  • add small utility to drop prefx from string to Basics
  • cleanup redundant HTTPClientProtocol which was used for RegistryClient testing but since deprecated
  • add and adjust tests

motication: preparation work for mixed graphs

changes:
* rename RegistryClient::listVersions API to getPackageMetadata and revise it to parse the link header that contains the alternative URLs for the package
* enhance RegistryClient::getIdentifers API to use codable for parsing the server result
* add small utility to drop prefx from string to Basics
* cleanup redundant HTTPClientProtocol which was used for RegistryClient testing but since deprecated
* add and adjust tests
@tomerd tomerd force-pushed the registry/mixed-graphs-01 branch from 210d5d9 to 5412d98 Compare February 16, 2022 03:02
@tomerd tomerd requested a review from yim-lee February 16, 2022 03:02
@tomerd
Copy link
Contributor Author

tomerd commented Feb 16, 2022

@swift-ci please smoke test

@tomerd tomerd added the ready Author believes the PR is ready to be merged & any feedback has been addressed label Feb 16, 2022
@tomerd tomerd merged commit dee6c2c into swiftlang:main Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Author believes the PR is ready to be merged & any feedback has been addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants