improve repository manager lookup concurrency control #4177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
tomerd
added
the
ready
tomerd
force-pushed
the
refactor/repository-manager-02
branch
from
8fa23cb to
29c50fa
Compare
|
@swift-ci please smoke test |
tomerd
force-pushed
the
refactor/repository-manager-02
branch
from
29c50fa to
2a35c4b
Compare
|
@swift-ci please smoke test |
tomerd
changed the title
motivation: improved concurency control and cleaer code changes: * use a seperate queue to schedule the lookup tasks to ensure oncurrency control is done correctly * create an sync version of lookup to help make maintaining the code easier, at least while git client is syn * reduce double queue overhead when Workspace::geContainer calls into RepositoryManager::lookup
tomerd
force-pushed
the
refactor/repository-manager-02
branch
from
2a35c4b to
c06e69f
Compare
|
@swift-ci please smoke test |
|
also required for #4173 |
abertelrud
approved these changes
Feb 28, 2022
tomerd
added a commit
to tomerd/swift-package-manager
that referenced
this pull request
Mar 1, 2022
motivation: improved concurrency control and cleaner code changes: * use a separate queue to schedule the lookup tasks to ensure concurrency control is done correctly * create a sync version of lookup to help make maintaining the code easier, at least while the git client is sync * reduce double queue overhead when Workspace::geContainer calls into RepositoryManager::lookup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: improved concurrency control and cleaner code
changes: