factor binary dependencies handling outside workspace class [nfc] #4197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivation: code handling binary dependencies has become complex and large, factor it out to its own class changes: * factor out the code that deals with downloading and extracting binary dependencies out of Workspace and into a dedicated struct * adjust workspace initiatilizers to allow customizing the BinaryArtifactsManager instead of the HTTPClient and Archiver that are in service of handling binary dependencies * adjjust call sites and test
|
@swift-ci please smoke test |
tomerd
added
the
ready
|
@swift-ci please smoke test macOS |
neonichu
approved these changes
Mar 4, 2022
abertelrud
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: code handling binary dependencies has become complex and long, factor it out to its own class
this is a non-functional change, only moving functionality around
changes: