PackageLoading: correct relative path construction #5501
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We would construct a `RelativePath` without rooting it, which would then be normalized and thus cause problems. Alter the path to validate the path is relative and then construct the `AbsolutePath` by rooting the relative path.
compnerd
requested review from
abertelrud,
neonichu,
tomerd and
elsh
as code owners
|
@swift-ci please smoke test |
tomerd
reviewed
May 13, 2022
| let subpath = try RelativePath(validating: value) | ||
| guard targetRoot.appending(subpath).isDescendantOfOrEqual(to: packagePath) else { | ||
| throw ModuleError.invalidHeaderSearchPath(subpath.pathString) | ||
| _ = try RelativePath(validating: value) |
There was a problem hiding this comment.
same comment as https://github.com/apple/swift-package-manager/pull/5484/files#r870728183
this change is too subtle and likely to be reverted by future maintainers as the intuitive thing to do is to not ignore the relative path returned by the constructor. we really do need to address the underlying issue first.
|
Yeah, I think that we can close this PR, I checked the current PackageLoading test failures - they seem to be related to path normalisation rather than relative path construction. Thanks for the reminder! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would construct a
RelativePathwithout rooting it, which would thenbe normalized and thus cause problems. Alter the path to validate the
path is relative and then construct the
AbsolutePathby rooting therelative path.