Tests: use RelativePath in XcodeprojTests for path references
#5514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adjusts the test expectations to use `RelativePath` to construct the path with the preferred platform path separator rather than the hardcoded `/`. This enables the test suite to pass on Windows.
compnerd
requested review from
abertelrud,
neonichu,
tomerd and
elsh
as code owners
|
@swift-ci please test |
tomerd
reviewed
May 16, 2022
| @@ -137,7 +137,7 @@ class PackageGraphTests: XCTestCase { | |||
| XCTAssertEqual(targetResult.commonBuildSettings.OTHER_LDFLAGS?.first, "$(inherited)") | |||
| XCTAssertEqual(targetResult.commonBuildSettings.OTHER_SWIFT_FLAGS?.first, "$(inherited)") | |||
| XCTAssertEqual(targetResult.commonBuildSettings.SKIP_INSTALL, "YES") | |||
| XCTAssertEqual(targetResult.target.buildSettings.xcconfigFileRef?.path, "../Overrides.xcconfig") | |||
| XCTAssertEqual(targetResult.target.buildSettings.xcconfigFileRef?.path, RelativePath(unsafeUncheckedPath: "../Overrides.xcconfig").pathString) | |||
There was a problem hiding this comment.
curios, why do we need to use the unsafeUncheckedPath variant?
There was a problem hiding this comment.
Because we cannot normalize ../Overrides.xcconfig without an anchor.
|
The current failures do seem to be outside of this set, so .... yeah, lets assume that this is no longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjusts the test expectations to use
RelativePathto constructthe path with the preferred platform path separator rather than the
hardcoded
/. This enables the test suite to pass on Windows.