Add diagnostics to use module aliasing when duplicate targets found #5606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves rdar://93218209
|
@swift-ci smoke test |
|
@swift-ci smoke test |
abertelrud
approved these changes
Jun 18, 2022
neonichu
added a commit
that referenced
this pull request
Sep 30, 2023
… found (#5606)" This reverts commit 33e05c7. We should not make this suggestion without better contextual awareness because it can often be confusing, e.g. when someone is already using a module alias in a case where it isn't supposed to work (see #6841). If we could find a way to confidently make the suggestion, we could bring it back, but currently it can be more confusing than not.
neonichu
added a commit
that referenced
this pull request
Oct 2, 2023
… found (#5606)" (#6961) This reverts commit 33e05c7. We should not make this suggestion without better contextual awareness because it can often be confusing, e.g. when someone is already using a module alias in a case where it isn't supposed to work (see #6841). If we could find a way to confidently make the suggestion, we could bring it back, but currently it can be more confusing than not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves rdar://93218209