Prepare SPM Targets for Process migration by specifying that callee should use TSCBasic.Process #5609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overcot
requested review from
abertelrud,
neonichu,
tomerd and
elsh
as code owners
…hould use TSCBasic.Process
Overcot
force-pushed
the
feature/prepareForProcessMigration
branch
from
66fd776 to
6119eac
Compare
tomerd
approved these changes
Jun 23, 2022
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically it marks all usage of Process as TSCBasic.Process
Motivation:
It is to address a problem of disambiguation that occurs when creating
Processinside SwiftBasics library. The motivation overall is driven by comment #5532 (comment)Modifications:
Specify explicitly that current
Processis fromTSCBasiclibrary. It is done in source code and testsResult:
The result is to make sure that adoption by targets of future
Processinside SwiftBasics to be incremental