Skip to content

allow use of warnings-as-errors while dependencies have supressed warnings #5612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

tomerd
Copy link
Contributor

@tomerd tomerd commented Jun 21, 2022

motivation: warnings-as-errors and suppress-warnings are mutually exclusive

changes:

  • do not pass warnings-as-errors for remote dependencies which use suppress-warnings
  • add test

…nings

motivation: warnings-as-errors and suppress-warnings are mutually exclusive

changes:
* do not pass warnings-as-errors for remote dependencies which use suppress-warnings
* add test
@tomerd
Copy link
Contributor Author

tomerd commented Jun 21, 2022

@swift-ci smoke test

@tomerd tomerd changed the title allow use of warnings-as-errors while dependencies have supressed war… allow use of warnings-as-errors while dependencies have supressed warnings Jun 21, 2022
@tomerd tomerd enabled auto-merge (squash) June 21, 2022 18:48
@tomerd tomerd merged commit dd38692 into swiftlang:main Jun 21, 2022
tomerd added a commit to tomerd/swift-package-manager that referenced this pull request Jun 21, 2022
…nings (swiftlang#5612)

motivation: warnings-as-errors and suppress-warnings are mutually exclusive

changes:
* do not pass warnings-as-errors for remote dependencies which use suppress-warnings
* add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants