Skip to content

[5.6] Do not test inferior Swift libraries on Darwin #5615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

neonichu
Copy link
Contributor

5.6 cherry-pick of #5611

This is needed on all active branches because CI will upgrade to macOS 12.

On platforms with ABI-stable Swift runtime libraries (currently only Darwin), we should not set `DYLD_LIBRARY_PATHS` to include the inferior Swift libs in `bootstrap` because compatibility issues can arise from SwiftPM's use of Foundation (which itself is a client of the stdlib) and from using dyld4 (which is used on macOS 12+).

rdar://88475529

(cherry picked from commit d045aa6)
@neonichu neonichu added the 5.6 label Jun 22, 2022
@neonichu neonichu requested a review from shahmishal June 22, 2022 16:57
@neonichu neonichu requested a review from abertelrud as a code owner June 22, 2022 16:57
@neonichu neonichu self-assigned this Jun 22, 2022
@neonichu neonichu requested review from tomerd and elsh as code owners June 22, 2022 16:57
@neonichu
Copy link
Contributor Author

@swift-ci please smoke test

@abertelrud abertelrud closed this Sep 21, 2022
@neonichu neonichu deleted the do-not-include-swift-libs-in-dyld-library-path-5.6 branch November 3, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants