improve test discovery to include inherited tests #5637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
changed the title
|
swiftlang/swift-tools-support-core#335 @swift-ci smoke test |
tomerd
force-pushed
the
radar/59655518
branch
2 times, most recently
from
f2469dd to
17b9571
Compare
motivation: test discovery on linux depends on index store test listing changes: * use new API from TSC that fixes the issue * adjust test * add docker setup for 5.7 rdar://59655518
|
swiftlang/swift-tools-support-core#335 @swift-ci smoke test |
neonichu
approved these changes
Jul 1, 2022
|
self hosted test expected to fails since they do not support cross repo testing (@shahmishal can that be fixed?) |
I think that's something we would need to work on -- the self-hosted tests use the regular package manifest and we would need a way to override the dependencies there in a clean way. Maybe something that could be feasible once we have explicit overrides? |
|
swiftlang/swift-tools-support-core#335 @swift-ci smoke test |
|
swiftlang/swift-tools-support-core#335 @swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: test discovery on linux depends on index store test listing
changes:
rdar://59655518