[5.7] 🍒 Stop using --gc-sections for Wasm target to protect metadata sections
#5648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns (swiftlang#5638) Now wasm-ld strips data segments referenced through __start/__stop symbols during GC, and it removes Swift metadata sections like swift5_protocols We should add support of SHF_GNU_RETAIN-like flag for __attribute__((retain)) to LLVM and wasm-ld. For now, just disable section GC for Wasm target. Context: llvm/llvm-project#55839 https://reviews.llvm.org/D126950#3558050
kateinoigakukun
requested review from
abertelrud,
neonichu,
tomerd and
elsh
as code owners
|
@swift-ci Please smoke test |
tomerd
approved these changes
Jul 11, 2022
airspeedswift
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #5638 because it's a regression happening since in 5.7
CC: @MaxDesiatov