Import _Concurrency where needed #5682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some environments we have to disable the implicit import of concurrency for reasons, so we need to explicitly import the module where needed. Note: ideally, we would catch this by adding `-disable-implicit-concurrency-module-import` to the bootstrap invocation of `swift-build`, but I wasn't able to get that working locally without the inferior `swift-build` crashing on me. I'll open a separate draft PR for that change that we can land once that has been figured out. rdar://97387827
|
@swift-ci please smoke test |
|
In #5683, I'll be adding the relevant options to bootstrap. |
tomerd
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some environments we have to disable the implicit import of concurrency for reasons, so we need to explicitly import the module where needed.
Note: ideally, we would catch this by adding
-disable-implicit-concurrency-module-importto the bootstrap invocation ofswift-build, but I wasn't able to get that working locally without the inferiorswift-buildcrashing on me. I'll open a separate draft PR for that change that we can land once that has been figured out.rdar://97387827