-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Improve search paths for XCFrameworks #5724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci please smoke test |
Just did a simple test: Built a local SwiftPM and just tried building my sample project with this patch applied instead of the standard toolchain 'swift build' one and it worked:
|
When packaging a Swift dylib as an XCFramework, its modules will be at the top-level, so that directory needs to become part of search paths. fixes #5723
084a3ce
to
dbea3ab
Compare
@swift-ci please smoke test |
@swift-ci please smoke test macOS |
@neonichu will this fix be in the next public release of Swift? (after Swift 5.7.1) |
I think we haven't branched for 5.8 yet, so that should be the case. |
Thanks! I appreciate the info 😄 |
When packaging a Swift dylib as an XCFramework, its modules will be at the top-level, so that directory needs to become part of search paths.
fixes #5723