Skip to content

Remove unused targets #5801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Remove unused targets #5801

merged 1 commit into from
Oct 10, 2022

Conversation

neonichu
Copy link
Contributor

@neonichu neonichu commented Oct 7, 2022

Looks like these may have been a prototype of some sort, but they haven't been referenced by the manifest for a while, so we haven't even been building/testing them.

Looks like these may have been a prototype of some sort, but they haven't been referenced by the manifest for a while, so we haven't even been building/testing them.
@neonichu neonichu requested a review from abertelrud as a code owner October 7, 2022 21:30
@neonichu neonichu self-assigned this Oct 7, 2022
@neonichu neonichu requested review from tomerd and elsh as code owners October 7, 2022 21:30
@neonichu
Copy link
Contributor Author

neonichu commented Oct 7, 2022

@swift-ci please smoke test

@neonichu
Copy link
Contributor Author

neonichu commented Oct 7, 2022

Also wondering if we should remove https://github.com/apple/swift-package-manager/blob/main/Tests/ExtraTests/Tests/ExtraTests/FSWatchTests.swift (the entire ExtraTests directory really). I don't think we have been running / maintaining these tests at all.

@tomerd
Copy link
Contributor

tomerd commented Oct 7, 2022

FSWatch is in TSC right now, maybe these should go there?

@neonichu neonichu merged commit 9ee2297 into main Oct 10, 2022
@neonichu neonichu deleted the remove-unused-targets branch October 10, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants