Introduce extraCXXFlags, deprecate extraCPPFlags
#5827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usually, CPP is used as an abbreviation for the C preprocessor, while CXX is used more commonly to refer to the C++ compiler. For this wider consistency, `extraCXXFlags` can be introduced as a replacement for `extraCPPFlags`.
MaxDesiatov
requested review from
abertelrud,
neonichu,
tomerd and
elsh
as code owners
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
neonichu
approved these changes
Oct 19, 2022
MaxDesiatov
added a commit
that referenced
this pull request
Nov 15, 2022
Currently, `destination.json` files only support absolute paths, which makes it hard to move cross-compilation sysroots between directories and copying them to different machines. This change support for relative paths in v2 scheme of `destination.json` files. The path is then normalized relative to the location of `destination.json` file. `struct DestinationInfo` is renamed to `DestinationInfoV1`. New `struct DestinationInfoV2` is added to handle the new version that supports relative paths. This is also used as an opportunity to make the schema more consistent with manifests for artifact bundles, in which properties use `camelCase` instead of `dash-case` naming. Also new in schema version 2 are `linkerFlags` and renaming of `extraCPPFlags` to `extraCXXFlags`, to follow up on #5827 and #5837.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Usually, CPP is used as an abbreviation for the C preprocessor, while CXX more commonly refers to the C++ compiler. We also use
cxxSettingsinPackage.swiftmanifest: https://developer.apple.com/documentation/packagedescription/target/cxxsettings.Modifications:
For this wider consistency,
extraCXXFlagsis introduced as a replacement forextraCPPFlags. The latter is then deprecated and is made a computed property that just returns the value ofextraCXXFlags.Result:
Users who are coming from C++ background can be more familiar with the codebase. In the next schema version of
destination.json(introduced in a future PR) we can use the new naming as well.