PackageModel: clean up naming of Destination properties
#5871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDesiatov
requested review from
abertelrud,
neonichu,
tomerd and
elsh
as code owners
|
@swift-ci please smoke test |
neonichu
approved these changes
Nov 3, 2022
|
Linux failure seems to be unrelated: |
|
@swift-ci please smoke test Linux |
1 similar comment
|
@swift-ci please smoke test Linux |
MaxDesiatov
added a commit
that referenced
this pull request
Nov 4, 2022
Introduced `sdkRootDir` replacing `sdk`, `toolchainBinDir` replacing `binDir`, and `destinationTriple` replacing `target` old names are marked as deprecated. Also added the new `hostTriple` property.
MaxDesiatov
added a commit
that referenced
this pull request
Nov 4, 2022
Introduced `sdkRootDir` replacing `sdk`, `toolchainBinDir` replacing `binDir`, and `destinationTriple` replacing `target` old names are marked as deprecated. Also added the new `hostTriple` property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Destinationtype has some properties with pretty short names based entirely on abbreviations or knowledge of context. It also can't store the triple of the host that supports this destination. Making names of properties consistent makes it more maintainable and readable.Modifications:
Introduced
sdkRootDirreplacingsdk,toolchainBinDirreplacingbinDir, anddestinationTriplereplacingtargetold names are marked as deprecated. Also added the newhostTripleproperty.Result:
Makes property names in the codebase more consistent, also incorporates some preparatory work I'm doing for #5812.