Close manifest cache DB before calling completion handlers #5881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
abertelrud
approved these changes
Nov 4, 2022
|
Hm, looks like this isn't working well: |
|
I think we should probably make a bigger change here actually, it doesn't seem right that we're calling the completion handler before closing the DB. |
Previously, we were relying on `defer` to close the database, but that would mean we're closing it when exiting the scope which is typically *after* we are calling completion handlers. It seems as if we should instead call them before. Related to rdar://101956252
neonichu
force-pushed
the
fix-defer-in-manifest-caching
branch
from
eda4114 to
e5124cc
Compare
neonichu
changed the title
defer in manifest caching
|
@swift-ci please smoke test |
abertelrud
approved these changes
Nov 4, 2022
tomerd
approved these changes
Nov 7, 2022
tomerd
reviewed
Nov 7, 2022
tomerd
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were relying on
deferto close the database, but that would mean we're closing it when exiting the scope which is typically after we are calling completion handlers. It seems as if we should instead call them before.Related to rdar://101956252