Commands: split SwiftPackageTool into multiple files #5883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDesiatov
requested review from
abertelrud,
neonichu,
tomerd and
elsh
as code owners
MaxDesiatov
force-pushed
the
maxd/swift-package-tool
branch
from
e7ebf3a to
1d10c37
Compare
|
@swift-ci please smoke test |
|
good idea 👍 |
MaxDesiatov
force-pushed
the
maxd/swift-package-tool
branch
from
1d10c37 to
b822f7b
Compare
|
@swift-ci please smoke test |
This reverts commit cf19c64 and restores the `--build-path` option. It also switches the `bootstrap` script back to using it so that we have an easy check that the option is still present.
|
@swift-ci please smoke test |
MaxDesiatov
force-pushed
the
maxd/swift-package-tool
branch
from
125cfbf to
a1279bd
Compare
…xd/swift-package-tool # Conflicts: # Sources/Commands/CMakeLists.txt # Sources/Commands/SwiftPackageTool.swift # Sources/CoreCommands/SwiftTool.swift
|
@swift-ci please smoke test |
tomerd
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
SwiftPackageTool.swiftis quite big, it would be great to split it into multiple files for easier maintenance.Modifications:
Moved
SwiftPackageToolsubcommands into separate files of newPackageToolssubdirectory.Result:
It's easier to look up a specific subcommand and maintain separate files than one big file.